Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) some opportunities to use diamond operator #25585

Merged
merged 2 commits into from
Aug 15, 2017
Merged

(refactor) some opportunities to use diamond operator #25585

merged 2 commits into from
Aug 15, 2017

Conversation

desmorto
Copy link
Contributor

@desmorto desmorto commented Jul 7, 2017

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

tvernum
tvernum reviewed Jul 7, 2017
View reviewed changes
core/src/test/java/org/elasticsearch/index/store/ExceptionRetryIT.java Outdated
@@ -128,7 +128,7 @@ protected void sendRequest(Connection connection, long requestId, String action,
refresh();
SearchResponse searchResponse = client().prepareSearch("index").setSize(numDocs * 2).addStoredField("_id").get();

Set<String> uniqueIds = new HashSet();
Set<String> uniqueIds = new HashSete<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have a typo here.

It's very helpful it you can get gradle to pass before raising a PR, so that these sorts of things get picked up by tooling rather than people needing to look at them.

@tvernum
Copy link
Contributor

tvernum commented Jul 7, 2017

@desmorto Can you please update the description of this PR with
(a) A description of what you're changing/why. If the PR is merged, then that text will form part of the commit message, so it's helpful if it contains something meaningful.
(b) Answers to the questions that are in the template. We can't do anything with PRs that haven't signed the Contributor Agreement.

@desmorto
Copy link
Contributor Author

desmorto commented Jul 7, 2017

This refactoring is for compliance with java 1.7 operator diamond. This feature is already used widely on project, just some pieces of code that are missing them. Sorry for the typo before.
I Also used grade assemble.

@yeikel
Copy link

yeikel commented Jul 11, 2017

@desmorto What @tvernum pointed out is that you misspelled HashSet as you put HashSete. I really don't see how your build passed with that.

@dakrone
Copy link
Member

dakrone commented Aug 15, 2017

@elasticmachine test this please

@dakrone dakrone merged commit 292dd8f into elastic:master Aug 15, 2017
@dakrone
Copy link
Member

dakrone commented Aug 15, 2017

Thanks @desmorto!

jasontedor added a commit to glefloch/elasticsearch that referenced this pull request Aug 16, 2017
@jasontedor
Merge branch 'master' into fix/24969
e1bc2ef 
* master: (458 commits)
  Prevent cluster internal `ClusterState.Custom` impls to leak to a client (elastic#26232)
  Add packaging test for systemd runtime directive
  [TEST] Reenable RareClusterStateIt#testDeleteCreateInOneBulk
  Serialize and expose timeout of acknowledged requests in REST layer (elastic#26189)
  (refactor) some opportunities to use diamond operator (elastic#25585)
  [DOCS] Clarified readme for testing a single page
  Settings: Add keystore.seed auto generated secure setting (elastic#26149)
  Update version information (elastic#25226)
  "result" : created -> "result" : "created" (elastic#25446)
  Set RuntimeDirectory (elastic#23526)
  Drop upgrade from full cluster restart tests (elastic#26224)
  Further improve docs for requests_per_second
  Docs disambiguate reindex's requests_per_second (elastic#26185)
  [DOCS] Cleanup link for ec2 discovery (elastic#26222)
  Fix document field equals and hash code test
  Use holder pattern for lazy deprecation loggers
  Settings: Add keystore creation to add commands (elastic#26126)
  Docs: Cleanup docs for ec2 discovery (elastic#26065)
  Fix NPE when `values` is omitted on percentile_ranks agg (elastic#26046)
  Several internal improvements to internal test cluster infra (elastic#26214)
  ...
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvernum tvernum tvernum left review comments

Assignees
No one assigned
Labels
>non-issue v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@desmorto @elasticmachine @tvernum @yeikel @dakrone @jimczi