Move more token filters to analysis-common module #25384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:Search Relevance/Analysis
75 tasks
nik9000
approved these changes
Jun 23, 2017
| @@ -458,7 +456,6 @@ public void testPrefixLength() throws IOException { | |||
| XContentBuilder mapping = XContentFactory.jsonBuilder().startObject().startObject("type1") | |||
| .startObject("properties") | |||
| .startObject("body").field("type", "text").field("analyzer", "body").endObject() | |||
| .startObject("body_reverse").field("type", "text").field("analyzer", "reverse").endObject() | |||
| @@ -17,10 +17,6 @@ | |||
| }, | |||
| "my":{ | |||
| "type":"myfilter" | |||
| }, | |||
There was a problem hiding this comment.
I wonder if it is time to remove this entire file somehow!
There was a problem hiding this comment.
Oh! I see. You don't need to get rid of it because you can plugin mocks into it. Great.
There was a problem hiding this comment.
Naming this the same as the one for compound analysis seems bad. Maybe each one should have its own name.
| @@ -67,6 +68,39 @@ public CommonAnalysisFactoryTests() { | |||
| filters.put("uppercase", UpperCaseTokenFilterFactory.class); | |||
| filters.put("ngram", NGramTokenFilterFactory.class); | |||
| filters.put("edgengram", EdgeNGramTokenFilterFactory.class); | |||
| filters.put("bulgarianstem", StemmerTokenFilterFactory.class); | |||
The following token filters were moved: stemmer, stemmer_override, kstem, dictionary_decompounder, hyphenation_decompounder, reverse, elision and truncate. Relates to elastic#23658
martijnvg
force-pushed
the
move_more_token_filters_to_analyis-commons_module2
branch
from
3ac20d1
to
a34f5fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following token filters were moved: stemmer, stemmer_override, kstem, dictionary_decompounder, hyphenation_decompounder, reverse, elision and truncate.
Relates to #23658