Postings highlighter deprecation #25073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
:Search Relevance/Highlighting
javanna
reviewed
Jun 6, 2017
|
|
||
| private static final String CACHE_KEY = "highlight-postings"; | ||
|
|
||
| @Override | ||
| public HighlightField highlight(HighlighterContext highlighterContext) { | ||
|
|
||
| deprecationLogger.deprecated("[postings] highlighter is deprecated, please use [unified] instead"); |
There was a problem hiding this comment.
this way we will issue a deprecation warning for each hit, each field. Should we try to do it for each document at least? or maybe we can do it for each request, that would be even better.
There was a problem hiding this comment.
Thanks, I tried to limit to one per request in this change:
31ee145
Can you take another look ?
nik9000
approved these changes
Jun 6, 2017
| @@ -60,8 +60,13 @@ This is repeated for every field and every document that needs highlighting. If | |||
| [[postings-highlighter]] | |||
| ==== Postings highlighter | |||
|
|
|||
| deprecated[5.5.0,This highlighter type is deprecated and will be removed. Please use the `unified` highlighter instead. ] | |||
jimczi
force-pushed
the
postings_highlighter_deprecation
branch
from
31ee145 to
9b6f1bb
Compare
This change adds a deprecation warning for removal in 6.0. Relates elastic#25028
jimczi
force-pushed
the
postings_highlighter_deprecation
branch
from
9c4eb4d to
89822b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
postingshighlighter is deprecated in Lucene and will be replaced by theunified.This change adds a deprecation warning for removal in 6.0.
Relates #25028