Ensure remote cluster is connected before fetching _field_caps
#24845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a cluster disconnects and comes back up we should ensure that we connected to the cluster before we fire the requests. Closes elastic#24763
javanna
approved these changes
May 24, 2017
| List<DiscoveryNode> knownNodes = new CopyOnWriteArrayList<>(); | ||
| try (MockTransportService seedTransport = startTransport("seed_node", knownNodes, Version.CURRENT); | ||
| MockTransportService discoverableTransport = startTransport("discoverable_node", knownNodes, Version.CURRENT)) { | ||
| DiscoveryNode seedNode = seedTransport.getLocalDiscoNode(); |
There was a problem hiding this comment.
can you fix the indentation here?
s1monw
added a commit
that referenced
this pull request
May 24, 2017
The test `testEnsureConnected` was accidentially introduces during #24845
s1monw
added a commit
that referenced
this pull request
May 29, 2017
) If a cluster disconnects and comes back up we should ensure that we connected to the cluster before we fire the requests. Closes #24763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cluster disconnects and comes back up we should ensure that
we connected to the cluster before we fire the requests.
Closes #24763