Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting: Deprecate file script settings #24555

Merged
merged 3 commits into from
May 9, 2017

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented May 9, 2017

File scripts have 2 related settings: the path of file scripts, and
whether they can be dynamically reloaded. This commit deprecates those
settings.

relates #21798

@rjernst rjernst added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >deprecation v5.5.0 v6.0.0 labels May 9, 2017
File scripts have 2 related settings: the path of file scripts, and
whether they can be dynamically reloaded. This commit deprecates those
settings.

relates elastic#21798
@rjernst rjernst force-pushed the deprecate_file_script_settings branch from bc22f1a to 0ee80b0 Compare May 9, 2017 00:51
@rjernst
Copy link
Member Author

rjernst commented May 9, 2017

@elasticmachine retest this please

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit ebd3e5f into elastic:master May 9, 2017
@rjernst rjernst deleted the deprecate_file_script_settings branch May 9, 2017 23:15
rjernst added a commit that referenced this pull request May 9, 2017
File scripts have 2 related settings: the path of file scripts, and
whether they can be dynamically reloaded. This commit deprecates those
settings.

relates #21798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >deprecation v5.5.0 v6.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants