-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept ingest simulate params as ints or strings #23885
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
hey @sneivandt, apologies for the late response. these changes look good overall! Jenkins, please test this |
@sneivandt thanks for the rebase. think you can add tests around this for other than that, changes look good! |
Hi @sneivandt sorry for the late response. I see you added tests (that I missed) Think you can rebase off the latest changes so that we can continue with your PR? |
…nt as either string or int (#23823)
…g document parsing.
Hey @talevy take a look now. Should be up to date. |
thanks @sneivandt. looks good! I'll just have our CI run through the checks jenkins, please test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Allow ingest simulate to parse _id, _index, _type, _routing and _parent as either string or int (#23823) * Generate data that includes Integer and String type fields for testing document parsing.
Update Ingest simulate to accept _id, _index, _type, _routing and _parent as either strings or ints.
Issue #23823.