Add FileSystemUtil method to read 'file:/' URLs #23020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
:Core/Infra/Core
Tim-Brooks
added a commit
that referenced
this pull request
Feb 7, 2017
This is related to #23020. There are some cases for where this method might be called with a URL to a file inside a jar. This commit allows this method to read URLs with a protocol of 'jar:/'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #22116 we are going to forbid usage of api
java.net.URL#openStream(). However in a number of places across thewe use this method to read files from the local filesystem. This commit
introduces a helper method
openFileURLStream(URL url)to read filesfrom URLs. It does specific validation to only ensure that
file:/urls are read.
Additionlly, this commit removes unneeded method
FileSystemUtil.newBufferedReader(URL, Charset). This method used theopenStream ()method which will soon be forbidden. Instead we use theFiles.newBufferedReader(Path, Charset).