Add methods requiring connect to forbidden apis

[Tim-Brooks]

This is related to #22116. This commit adds calls that require
SocketPermission connect to forbidden APIs.

The following calls are now forbidden:

• java.net.URL#openStream()
• java.net.Socket#connect(java.net.SocketAddress)
• java.net.Socket#connect(java.net.SocketAddress, int)
• java.nio.channels.SocketChannel#open(java.net.SocketAddress)
• java.nio.channels.SocketChannel#connect(java.net.SocketAddress)

[s1monw]

LGTM but FileSystemUtils didn't like it.. feel free to push once the build passes

[Tim-Brooks]

Hey @s1monw - yeah there were a few places where I missed openStream(). So I'll submit updates.

For the FileSystemUtils do you just want me to suppress forbidden? Another option is to not use URL (I think). Most of the FileSystemUtils methods deal with paths. And both callers of newBufferedReader originate with a Path.

I could change:

public static BufferedReader newBufferedReader(URL url, Charset cs) throws IOException {
    CharsetDecoder decoder = cs.newDecoder();
    Reader reader = new InputStreamReader(url.openStream(), decoder);
    return new BufferedReader(reader);
}

To:

public static BufferedReader newBufferedReader(Path path, Charset cs) throws IOException {
    return Files.newBufferedReader(path, cs);
}

Or not have that method and just call Files.newBufferedReader(path, cs). But maybe I am missing a reason that we need to change these Path instances to URL? Or maybe there is a reason we don't want to use NIO in this case?

[s1monw]

Or not have that method and just call Files.newBufferedReader(path, cs).

++ just trash that method! good catch

[Tim-Brooks]

@s1monw can you give me an updated review based on my changes please?

[s1monw]

@elasticmachine test this please

[s1monw]

LGTM provided the tests pass