Remove connect SocketPermissions from core #22797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to elastic#22116. Core no longer needs `SocketPermission` `connect`. This permission is relegated to these modules/plugins: - transport-netty4 module - reindex module - repository-url module - discovery-azure-classic plugin - discovery-ec2 plugin - discovery-gce plugin - repository-azure plugin - repository-gcs plugin - repository-hdfs plugin - repository-s3 plugin And for tests: - mocksocket jar - rest client - httpcore-nio jar - httpasyncclient jar
Tim-Brooks
added
:Core/Infra/Core
|
A couple notes:
|
Tim-Brooks
changed the title
s1monw
approved these changes
Jan 27, 2017
| @@ -55,8 +55,8 @@ grant { | |||
| // third party code, to safeguard these against unprivileged code like scripts. | |||
| permission org.elasticsearch.SpecialPermission; | |||
|
|
|||
| // Allow connecting to the internet anywhere | |||
| permission java.net.SocketPermission "*", "connect,resolve"; | |||
| // Allow host/ip name service lookups | |||
4 tasks
jasontedor
requested changes
Feb 2, 2017
| permission java.net.SocketPermission "*", "connect"; | ||
| }; | ||
|
|
||
| grant codeBase "${codebase.httpcore-nio-4.4.5.jar}" { |
There was a problem hiding this comment.
Can you add comments to the places where these dependencies are defined that if the version is changed then the version needs to be updated here too? (This comment applies to all of the dependencies for which we have to supply these permissions.)
jasontedor
requested changes
Feb 2, 2017
| }; | ||
|
|
||
|
|
||
| grant codeBase "${codebase.rest-6.0.0-alpha1-SNAPSHOT.jar}" { |
There was a problem hiding this comment.
Does this one deserve a comment too, above the elasticsearch version in version.properties?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permission is relegated to these modules/plugins:
And for tests: