-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Painless: Add augmentation to String for base 64 #22665
Conversation
We don't want to expose `String#getBytes` which is required for `Base64.getEncoder.encode` to work because we're worried about character sets. This adds `encodeBase64` and `decodeBase64` methods to `String` in Painless that are duals of one another such that: `someString == someString.encodeBase64().decodeBase64()`. Both methods work with the UTF-8 encoding of the string. Closes elastic#22648
Hrm, I'll need to add documentation for this too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making this change.
We don't want to expose `String#getBytes` which is required for `Base64.getEncoder.encode` to work because we're worried about character sets. This adds `encodeBase64` and `decodeBase64` methods to `String` in Painless that are duals of one another such that: `someString == someString.encodeBase64().decodeBase64()`. Both methods work with the UTF-8 encoding of the string. Closes #22648
Thanks for reviewing @jdconrad and thanks for fixing my tags @clintongormley! |
* master: (117 commits) Add missing serialization BWC for disk usage estimates Expose disk usage estimates in nodes stats S3 repository: Deprecate specifying credentials through env vars, sys props, and remove profile files (elastic#22567) Fix Eclipse project generation Fix deprecation logging for lenient booleans Remove @Header we no longer need Make lexer abstract [Docs] Remove outdated info about enabling/disabling doc_values (elastic#22694) Move lexer hacks to EnhancedPainlessLexer Fix incorrect args order passed to createAggregator Improve painless's javadocs Add TestWithDependenciesPlugin to build (elastic#22646) Add parsing from xContent to SearchProfileShardResults and nested classes (elastic#22649) Add unit tests for FiltersAggregator (elastic#22678) Don't register search response listener in transport clients unmute FieldStatsIntegrationIT.testGeoPointNotIndexed, fix already pushed Mute FieldStatsIntegrationIT.testGeoPointNotIndexed, for now Painless: Add augmentation to string for base 64 (elastic#22665) Fix NPE on FieldStats with mixed cluster on version pre/post 5.2 (elastic#22688) Add parsing methods for UpdateResponse (elastic#22586) ...
Is there any chance to get this into a stable release of 5.2.x? |
Not likely. As a policy we don't backport enhancements to patch releases.
Sorry!
…On Wed, Feb 22, 2017, 9:44 PM Sebastian Unger ***@***.***> wrote:
Is there any chance to get this into a stable release of 5.2.x?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#22665 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLorZLDvltSGNDloyf-pGQKYfYk-tGks5rfPKagaJpZM4LmAq->
.
|
Any idea when 5.3 will be released? |
I'm really sorry @sebunger but we do not provide release dates. |
We don't want to expose
String#getBytes
which is required forBase64.getEncoder.encode
to work because we're worried aboutcharacter sets. This adds
encodeBase64
anddecodeBase64
methods to
String
in Painless that are duals of one anothersuch that:
someString == someString.encodeBase64().decodeBase64()
.Both methods work with the UTF-8 encoding of the string.
Closes #22648