Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change occurs starting major version 2 #22592

Closed
wants to merge 1 commit into from
Closed

Conversation

jonmcoe
Copy link

@jonmcoe jonmcoe commented Jan 12, 2017

related #6677

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?

@jonmcoe
Copy link
Author

jonmcoe commented Jan 12, 2017

i just signed the above, got/verified the email. Don't know when status change hits or if i am supposed to do something else

@clintongormley
Copy link
Contributor

Hi @jonmcoe

Thanks for the PR but this deprecation happened in 1.0.0, not 2.0.0. Also, we no longer accept PRs for ancient versions like 1.4

thanks anyway

@jonmcoe
Copy link
Author

jonmcoe commented Jan 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants