Wrap netty accept/connect ops with doPrivileged #22572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to elastic#22116. netty channels require socket `connect` and `accept` privileges. Netty does not currently wrap these operations with `doPrivileged` blocks. These changes extend the netty channels and wrap calls to the relevant super methods in doPrivileged blocks.
Tim-Brooks
added
:Core/Infra/Core
|
This change should prevent removing socket permissions from core being blocked by Netty's release cycle. |
Tim-Brooks
added
:Distributed Coordination/Network
4 tasks
|
The change looks good to me, but I wonder if we should just get rid of the blocking implementation? |
++ to get rid of blocking @tbrooks8 do you wanna take a look at this in a different PR? |
|
Yes. I can do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #22116. netty channels require socket
connectandacceptprivileges. Netty does not currently wrap these operationswith
doPrivilegedblocks. These changes extend the netty channelsand wrap calls to the relevant super methods in doPrivileged blocks.