Move IfConfig.logIfNecessary call into bootstrap #22455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
force-pushed
the
move_ifconfig
branch
from
b24b1d6 to
3b54406
Compare
jasontedor
reviewed
Jan 6, 2017
|
|
||
| private static final Logger logger = Loggers.getLogger(IfConfig.class); | ||
| private static final String INDENT = " "; | ||
|
|
||
| /** log interface configuration at debug level, if its enabled */ | ||
| static void logIfNecessary() { | ||
| public static void logIfNecessary() { | ||
| if (logger.isDebugEnabled()) { | ||
| try { |
There was a problem hiding this comment.
I was curious about this try block and I note that it currently catches SecurityException which should not be needed anymore with this change. Can we remove it now?
There was a problem hiding this comment.
I removed catching SecurityException. I think we still need the try and catch for IOException.
This is related to elastic#22116. A logIfNecessary() call makes a call to NetworkInterface.getInterfaceAddresses() requiring SocketPermission connect privileges. By moving this to bootstrap the logging call can be made before installing the SecurityManager.
Tim-Brooks
force-pushed
the
move_ifconfig
branch
from
3b54406 to
56acd43
Compare
clintongormley
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #22116. A logIfNecessary() call makes a call to
NetworkInterface.getInterfaceAddresses() which requires SocketPermission connect
privileges. By moving this to bootstrap the logging call can be made before
installing the SecurityManager.
As a note:
IFConfig and its method need to be made public in order for this to work. Another option would be to move the class into a different package - but that would cause issues as it depends on package private methods in NetworkUtils.