[TEST] Check static test state after suite scoped cluster is shut down #21256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @jasontedor |
ywelsch
added a commit
that referenced
this pull request
Nov 2, 2016
#21256) Checks on static test state are run by an @after method in ESTestCase. Suite-scoped tests in ESIntegTestCase only shut down in an @afterclass method, which executes after the @after method in ESTestCase. The suite-scoped cluster can thus still execute actions that will violate the checks in @after without those being caught. A subsequent test executing within the same JVM will fail these checks however when @after gets called for that test. This commit adds an explicit call to check the static test state after the suite-scoped cluster has been shut down.
ywelsch
added a commit
that referenced
this pull request
Nov 2, 2016
#21256) Checks on static test state are run by an @after method in ESTestCase. Suite-scoped tests in ESIntegTestCase only shut down in an @afterclass method, which executes after the @after method in ESTestCase. The suite-scoped cluster can thus still execute actions that will violate the checks in @after without those being caught. A subsequent test executing within the same JVM will fail these checks however when @after gets called for that test. This commit adds an explicit call to check the static test state after the suite-scoped cluster has been shut down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks on static test state are run by an
@Aftermethod inESTestCase. Suite-scoped tests inESIntegTestCaseonly shut down in an@AfterClassmethod, which executes after the@Aftermethod in ESTestCase. The suite-scoped cluster can thus still execute actions that will violate the checks in@Afterwithout those being caught. A subsequent test executing within the same JVM will fail these checks however when@Aftergets called for that test.This commit adds an explicit call to check the static test state after the suite-scoped cluster has been shut down.