Throw exception when multiple field names are provided as part of query short syntax #19871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… its short version
…elds in its short version
… its short version
|
@tlrx this should address your comment from #19791 (comment) . Can you have a look please? |
| @@ -309,6 +309,10 @@ protected void doXContent(XContentBuilder builder, Params params) throws IOExcep | |||
| } | |||
| } | |||
| } else { | |||
| if (fieldName != null) { | |||
There was a problem hiding this comment.
Could this be a method in AbstractQueryBuilder? Something like throwParseExceptionOnMultipleFields(String queryName, String fieldName, String currentName)?
|
Left a comment, thanks for doing this @javanna ! |
…ields are provided
…provided in a query that support one field only This makes sure that error messages are unified, and makes us save a few lines of code too.
…ith all other queries
|
@tlrx I pushed some new commits that should address your comment |
|
LGTM, thanks! |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #19791 we made sure that our query parsers throw error whenever they encounter multiple field names if only one is required. This PR covers the same situation for queries short syntax.