Fail doc tests when any shard fails #18979
Merged
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>docs
| * framework doesn't allow us to has assertions in the setup | ||
| * section so we have to skip it there. | ||
| */ | ||
| if (false == inSetup && false == path.startsWith('_cat')) { |
There was a problem hiding this comment.
can you add a comment about the _cat exclusion as well?
|
LGTM |
nik9000
force-pushed
the
painless_fail_when_bad
branch
from
780ae26 to
c627b63
Compare
ES only sends a non-200 response all shards fail but we should fail the tests generated by docs if any of them fail. Depending on the outcome of elastic#18978 this might be a temporary workaround.
nik9000
force-pushed
the
painless_fail_when_bad
branch
from
c627b63 to
6569d35
Compare
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES only sends a non-200 response all shards fail but we should
fail the tests generated by docs if any of them fail.
Depending on the outcome of #18978 this might be a temporary
workaround.