Remove support for sorting terms aggregation by ascending count #18940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>breaking
review
:Analytics/Aggregations
| @@ -26,3 +26,7 @@ for `from` and `to` anymore. | |||
| `size: 0` is no longer valid for the terms, significant terms and geohash grid | |||
| aggregations. Instead a size should be explicitly specified with a number greater | |||
| than zero. | |||
|
|
|||
| ==== `order: {"count": "desc"}` on Terms | |||
There was a problem hiding this comment.
should it be s/desc/asc/ ?
|
LGTM, can you put a comment on elastic/kibana#6833 saying we are moving forward on this? |
|
Sure, thanks @jpountz ! |
|
@jimferenczi Let's add deprecation logging on 2.4/2.x? |
|
The functionality is deprecated in 2.4/2.x but this PR has been reverted since it requires changes in Kibana. I'll merge it after the alpha release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17614