-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display plugins versions #18683
Display plugins versions #18683
Conversation
This is useful to determine if a plugin needs to be updated when using deployment automation solution (like Ansible).
The verbose option was extended to display all plugin properties in #18051. |
Yes I saw but the output is on multiples lines (ie. harder to parse with an automation tool). The verbose output is still useful for human. |
Human consumption is all you can really do. Knowing the plugin version doesn't tell you if it needs updating. Any time you update elasticsearch, plugins need to be updated, because they currently must be built against each specific version of elasticsearch. I think the non verbose output should stay as simply listing the plugin names installed, eg like |
+1 |
But you can still have a new version of a plugin without a new version of Elasticsearch ?
"Make everything as simple as possible, but not simpler". I think the plugin version is an important information and Here's some benefits:
Right now, in Ansible the basic idea is remove everything, install everything: https://github.com/elastic/ansible-elasticsearch/blob/master/tasks/elasticsearch-plugins.yml#L20 😒 |
That is what must happen for all official elasticsearch plugins. You are correct that community plugins may release multiple versions per elasticsearch version. But knowing what version is currently installed of a community plugin does not tell you anything about whether there is another version, and upgrading elasticsearch means another version of that community plugin must be installed. |
Ansible will know because I will tell him to install a (newer) version for this plugin. Being able to determine if I need to remove a community plugin in order to install a newer version will be really useful. |
We discussed it on fix it friday and found that it could be a nice feature to have. We don't see any drawback by adding this. I'm changing the label to "review". @rjernst As you were not available for this Fix It friday session, feel free to comment and raise any objection if any and change back the label to "discuss". |
Thanks @dadoonet ! |
@dadoonet Any news ? |
This LGTM, I will merge this |
@Mogztter merged this, thanks! |
Backported to 5.x and 5.0 |
Thanks @dakrone! I was planning to merge it today! \o/ |
Thanks \o/ |
This has been reverted in #20807. |
Wait what... but why ? 😭 |
For the initial reasons given against this PR and additionally as elaborated in #20668. |
Just read #20668
Fair enough but where can I find a machine-readable API ? |
There isn't one, but that does not mean we should mix the two.
I'm wondering why you don't unconditionally uninstall and then install the right version? |
This is useful to determine if a plugin needs to be updated when using deployment automation solution (like Ansible).
A similar feature is now available in Kibana: elastic/kibana#7221