Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort plugins in list plugins command #18260

Merged
merged 1 commit into from
May 11, 2016
Merged

Sort plugins in list plugins command #18260

merged 1 commit into from
May 11, 2016

Conversation

jasontedor
Copy link
Member

This commit modifies the list plugins command to produce deterministic
output by sorting the plugins by comparing paths.

Relates #18051

@jasontedor
Sort plugins in list plugins command
85dbb85 
This commit modifies the list plugins command to produce deterministic
output by sorting the plugins by comparing paths.
@nik9000
Copy link
Member

nik9000 commented May 11, 2016

LGTM

@jasontedor
Copy link
Member Author

Note that DirectoryStream does not guarantee the ordering of iterations, and this is leading to test failures. It probably makes sense to have the output sorted anyway.

@jasontedor jasontedor merged commit 5f0cc79 into elastic:master May 11, 2016
@jasontedor jasontedor deleted the deterministic-list-plugins branch May 11, 2016 02:06
@jasontedor
Copy link
Member Author

Thanks @nik9000!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Core/Infra/Plugins Plugin API and infrastructure >non-issue v5.0.0-alpha3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasontedor @nik9000 @clintongormley