Elasticsearch should reject dynamic templates with unknown match_mapping_type.
#17285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>enhancement
:Search Foundations/Mapping
jpountz
force-pushed
the
fix/template_validate_match_mapping_type
branch
2 times, most recently
from
24a4c8d to
54be98e
Compare
|
LGTM. For the future around this, it would be nice if this weren't a public enum. It seems like this enum is really used in place of a map. |
Agreed. we will want to collapse the mapper sub packages at some point (waiting to be done with points integration before doing so). |
jpountz
added
v5.0.0-alpha2
v6.0.0-alpha1
and removed
v6.0.0-alpha1
v5.0.0-alpha2
labels
|
@jpountz this has a +1, should it be merged? |
…ping_type`. elastic#17285 When looking at the logstash template, I noticed that it has definitions for dynamic temilates with `match_mapping_type` equal to `byte` for instance. However elasticsearch never tries to find templates that match the byte type (only long or double as far as numbers are concerned). This commit changes template parsing in order to ignore bad values of `match_mapping_type` (given how the logstash template is popular, this would break many upgrades otherwise). Then I hope to fail the parsing on bad values in 6.0.
jpountz
force-pushed
the
fix/template_validate_match_mapping_type
branch
from
54be98e to
0854b03
Compare
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Dec 12, 2016
When using dynamic templates, ES will now throw an exception if a `match_mapping_type` is used that doesn't correspond to an actual type. Relates to elastic#17285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the logstash template, I noticed that it has definitions for
dynamic temilates with
match_mapping_typeequal tobytefor instance.However elasticsearch never tries to find templates that match the byte type
(only long or double as far as numbers are concerned). This commit changes
template parsing in order to ignore bad values of
match_mapping_type(givenhow the logstash template is popular, this would break many upgrades
otherwise). Then I hope to fail the parsing on bad values in 6.0.
Relates to #16945