Aggregations Refactor: Refactor Top Hits Aggregation #15566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Inject | ||
| public TransportValidateQueryAction(Settings settings, ThreadPool threadPool, ClusterService clusterService, | ||
| TransportService transportService, IndicesService indicesService, | ||
| ScriptService scriptService, PageCacheRecycler pageCacheRecycler, | ||
| BigArrays bigArrays, ActionFilters actionFilters, IndexNameExpressionResolver indexNameExpressionResolver) { | ||
| BigArrays bigArrays, ActionFilters actionFilters, | ||
| IndexNameExpressionResolver indexNameExpressionResolver, FetchPhase fetchPhase) { |
There was a problem hiding this comment.
can you aligne indentation with existing code?
There was a problem hiding this comment.
I just pushed a commit to address these issues. Hopefully I managed to catch them all
|
This looks good to me. The FetchPhase wiring is a bit invasive but I have no idea how to make it better. :( |
|
LGTM |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.