Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregations Refactor: Refactor Sampler Aggregation #15418

Merged
merged 1 commit into from
Dec 21, 2015
Merged

Aggregations Refactor: Refactor Sampler Aggregation #15418

merged 1 commit into from
Dec 21, 2015

Conversation

colings86
Copy link
Contributor

No description provided.

@colings86
Copy link
Contributor Author

Note that this PR includes splitting the sampler aggregation into "sampler" and "diversified_sampler" aggregations for the API to make validation and parsing easier

@clintongormley clintongormley mentioned this pull request Dec 14, 2015
Closed
@colings86 colings86 force-pushed the feature/aggs-refactoring branch 2 times, most recently from 97cbdb8 to b147bf3 Compare December 15, 2015 12:01
jpountz
jpountz reviewed Dec 18, 2015
View reviewed changes
...g/elasticsearch/search/aggregations/bucket/sampler/DiversifiedSamplerAggregationBuilder.java

@Override
protected XContentBuilder doInternalXContent(XContentBuilder builder, Params params) throws IOException {
// builder.startObject();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there value in keeping this commented out?

@jpountz
Copy link
Contributor

jpountz commented Dec 18, 2015

I actually like the split. I'm wondering that we might rename sampler to eg. quality_sampler to make it clearer how it works (as opposed to eg. a random sampler?).

@colings86 colings86 force-pushed the feature/aggs-refactoring branch from 4fbfde6 to cbcccb3 Compare December 18, 2015 14:04
@colings86
Copy link
Contributor Author

@jpountz I pushed a commit with your suggestions implemented. I'm not a fan of quality_sampler as the diversified_sampler can also be thought of as sampling for quality purposes. Personally I think sampler is fine as its the simple no frills version of sampling
/cc @markharwood

@jpountz
Copy link
Contributor

jpountz commented Dec 18, 2015

LGTM

@colings86 colings86 merged commit 27a5812 into elastic:feature/aggs-refactoring Dec 21, 2015
@colings86 colings86 deleted the refactor/samplerAgg branch December 21, 2015 09:32
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Search Refactoring labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpountz jpountz

Labels
:Analytics/Aggregations Aggregations :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colings86 @jpountz @clintongormley