-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic reindex implementation #15125
Merged
Merged
Basic reindex implementation #15125
Changes from 123 commits
Commits
Show all changes
129 commits
Select commit
Hold shift + click to select a range
839bb21
Basic index-by-search
nik9000 e918bc1
Fix vagrant tests
nik9000 39e228e
Docs
nik9000 7501c00
Basic REST
nik9000 eee9583
Remove leftovers
nik9000 f4ec860
tabs!
nik9000 542c656
More docs
nik9000 d02f277
Copy routing
nik9000 e5ae49f
Add support for preserving external versions
nik9000 169e45e
Be more careful with the search request
nik9000 6db33aa
Clean up rest
nik9000 81430f9
More docs and tests
nik9000 f81e4e4
Fix more validation
nik9000 dd8fa09
Add support for routing
nik9000 222c986
Remove file that is no longer needed
nik9000 f9a3ae0
Add test for updating in place
nik9000 d40767e
Add support for op_type
nik9000 85ca3be
Move size override out of builder
nik9000 e562f35
Lots of version related things
nik9000 b96b218
More versioning work
nik9000 0be4b29
Preserve version by default reindexing
nik9000 6e7650c
Docs
nik9000 a3cc171
Start fixing response format
nik9000 6f3e563
Return failures
nik9000 f622e36
Rest tests for failures and batches
nik9000 630f26c
Squash index-by-search into on package
nik9000 79ee748
Add warning about atomicity to docs
nik9000 012336e
Rename version type and fix typo
nik9000 4e016fb
More rename version type
nik9000 3f67488
Simplify failure handling
nik9000 ee981a4
Start building ReindexInPlace
nik9000 c3a3db8
Fixup reindex and get tests passing
nik9000 f9d4e40
More reindex support
nik9000 e3e5d82
More reindex tests
nik9000 4b285ff
Hack to support body content
nik9000 04506e1
Remove parsers we can't use
nik9000 6f438b4
Add support for update scripts
nik9000 ab19a8a
Script support fixes
nik9000 4f8f14a
Get run picking up groovy
nik9000 7fc9f2d
_index_by_search's op_type parameter
nik9000 dee79c5
Revive update while indexing test
nik9000 0360bca
index-by-search can't write where it reads
nik9000 f86cd42
Rename index -> dest
nik9000 d6050d4
Add convenience destination methods to build
nik9000 8e5a3a6
More convenience methods in builder
nik9000 4bb66c2
Rename "search" to "source"
nik9000 df0ee51
Switch implementation to client
nik9000 3977010
Share script with reindex
nik9000 ae59719
Start adding metadata to scripts
nik9000 c2947a2
Add support for changing routing and parent
nik9000 5288788
Test changing parent and routing
nik9000 73075e6
Change definition of batches
nik9000 c4836ac
More cleanup in preparation for BulkProcessor
nik9000 865d694
Fix batches better this time
nik9000 1c68e61
Cleanup
nik9000 2b924eb
Cleanup
nik9000 5c9911e
Rename plugin to reindex
nik9000 a9cc567
Rename reindex->update-by-query
nik9000 4924475
Rename index-by-search->reindex
nik9000 b676ea8
Finish rename
nik9000 5b27eef
Drop version_type from update-by-query
nik9000 b113f0a
Rename docs
nik9000 82e2ead
Rewrite docs for the new world
nik9000 3459b28
Add more strict checks after scripts
nik9000 4140b00
Support reindex scripts changing metadata
nik9000 e4947f0
More renames
nik9000 c977217
Remove op_type from reindex
nik9000 14b7560
Fix funky layout in reindex source
nik9000 6504b40
docs
nik9000 e26d501
Add reindex parameter
nik9000 927b0d4
Consistency and timeout parameters
nik9000 aff9dfc
[docs] Add routing example
nik9000 3d26594
Fix some nocommits
nik9000 b1a2a96
Remove another nocommit
nik9000 36beb8d
Remove another nocommit
nik9000 96f9a86
Add round trip tests
nik9000 8759aed
Remove leftovers
nik9000 98dd95a
Revert new VersionType
nik9000 626e074
Revert test for new VersionType
nik9000 e396e6f
more docs
nik9000 7869a99
Move script tests into a qa module
nik9000 ba4e73e
Move building the bulk onto generic thread pool
nik9000 9c2b508
Fix out of date comments
nik9000 6107250
Return an error when the request fails
nik9000 12d7c80
Add missing license headers
nik9000 b5bce59
Docs fixes
nik9000 2e038ba
Implement BulkShardRequest.toString
nik9000 3c87503
Status names -> status codes
nik9000 cb98b2d
Cleanups from comments
nik9000 06de720
Use FieldMappers field names
nik9000 04d2912
Fixes from comments
nik9000 c4e7007
Replace -1 with a constant
nik9000 da38415
Refactor to remove duplication
nik9000 d43a968
Document source/src alias
nik9000 0461940
Document dest/destination alias
nik9000 4d4d93f
Updates from comments
nik9000 be501c7
unmodifiable list
nik9000 184123f
Let IOException bubble
nik9000 0c3f1b0
Rename constant
nik9000 23aaa61
Allow user to override scroll_size
nik9000 fe1d36d
More renames
nik9000 82c318a
Remove ?
nik9000 906f455
Add to the list of official plugins
nik9000 088a978
Changes from comments
nik9000 022cddb
OptionalStreamable!
nik9000 5c1e6da
Docs updates
nik9000 c0bc003
Help should include reindex
nik9000 e076531
Some fixes from review
nik9000 f4fd2f6
Remove duplicate check
nik9000 a73c252
Switch to getters in response
nik9000 384a0cb
Remove {}
nik9000 fa72146
Remove superfluous continue
nik9000 fb3d418
Validate timestamp and ttl aren't set
nik9000 9582876
Updates from comments
nik9000 354f7e0
Getters
nik9000 6831b4f
Tighter try
nik9000 6c295d2
Setters
nik9000 ffb6ed1
Remove useless continue
nik9000 d1363ef
Test that thread pool rejections are reported
nik9000 aac3ddd
Properly fail on shard failures
nik9000 1dc46e9
Start moving scripting tests to unit tests
nik9000 00947a8
Move script tests to unit tests
nik9000 8e49b35
Move alias checking testing into unit tests
nik9000 c0f3635
[docs] Make a list of metadata
nik9000 8e19e4f
[docs] Describe timeout
nik9000 6b85c37
[doc] Add more callouts
nik9000 e07a49b
Default conflicts to ignore
nik9000 ae8dbe2
Remove src and destination
nik9000 a8a3467
Move metadata tests to unit tests
nik9000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaks compatibility with old clients. In case of backport, we should be careful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. And I will backport it. But I think its just a think to keep in mind for then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we put //NORELEASE in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there is any need to have that for master though.