Make _type use doc values #14783
Merged
Make _type use doc values #14783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_type should have got doc values with the change to default doc values. However, due to how metadata fields have separate builders and special constructors, it was not picking it up. This change updates the field type for _type to have doc values. closes elastic#14781
rjernst
added
:Search Foundations/Mapping
|
LGTM. This will also help index sorting on _type once implemented :) |
|
What type of docvalues is it? I dont see it explicit. Can we ensure it is SORTED not SORTED_SET and not BINARY? |
|
Looks like it is SORTED_SET at the moment (already was in 1.x when it was enabled). I will create a new PR to change it to SORTED. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_type should have got doc values with the change to default doc values.
However, due to how metadata fields have separate builders and special
constructors, it was not picking it up. This change updates the field
type for _type to have doc values.
closes #14781