Refactor Geohash Grid Aggregation #14138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if (requiredSize == 0) { | ||
| requiredSize = Integer.MAX_VALUE; |
There was a problem hiding this comment.
I was curious why this is set to Integer.MAX_VALUE? Would we not want to reset it to DEFAULT_MAX_NUM_CELLS?
There was a problem hiding this comment.
So we have a loose convention that size: 0 means get all buckets. I personally don't like it but we have to keep it for now I guess as this refactor should be backwards compatible
colings86
force-pushed
the
feature/aggs-refactoring
branch
17 times, most recently
from
78878b3 to
7e316ba
Compare
| throw new SearchParseException(context, "Unexpected token " + token + " in [" + aggregationName + "].", | ||
| parser.getTokenLocation()); | ||
| Integer size = (Integer) otherOptions.get(GeoHashGridParams.FIELD_SIZE); | ||
| if (size != null) { |
|
LGTM, just found some indentation issues |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.