Deprecate _search/exists in favour of regular _search with size 0 and terminate_after 1 #13910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
:Search/Search
|
Nice. Perhaps add a section to the search API docs entitled "Fast check for any matching docs" or similar? |
|
+1 on documenting this "recipe" |
|
+1 maybe @debadair can help documenting that? |
|
I pushed a new commit to log a deprecation warning when search exists is used. Agreed on the additional documentation needed, I would open a follow-up PR though as that one would need to go to master too. Is that ok? |
|
LGTM |
| @@ -634,16 +634,19 @@ public CountRequestBuilder prepareCount(String... indices) { | |||
|
|
|||
| @Override | |||
| public ActionFuture<ExistsResponse> exists(final ExistsRequest request) { | |||
| deprecationLogger.deprecated("search exists api is deprecated and will be removed in the next major version, use search with size set 0 and terminate_after set to 1 instead"); | |||
… terminate_after 1 Relates to elastic#13682
javanna
force-pushed
the
deprecation/search_exists
branch
from
2896974 to
e7e09e2
Compare
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Nov 9, 2015
Relates to elastic#13910 Closes elastic#14393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
_search/existsin favour of regular_searchwithsizeset to0andterminate_afterset to1.Relates to #13682