Split HasParentQueryParser into toQuery and formXContent #13408
Merged
+440
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private static final HasParentQueryBuilder PROTOTYPE = new HasParentQueryBuilder("", EmptyQueryBuilder.PROTOTYPE); |
There was a problem hiding this comment.
I see that you put the prototype in the parser rather that in the builder. That is because it's the only place where it's used I guess (getBuilderPrototype)? looks good
There was a problem hiding this comment.
yeah it was really just used there :) so I was able to make it private
There was a problem hiding this comment.
makes sense, was about to say we could move all existing prototypes to parsers, but if we then we want to merge parser and builder, let's not do it till we made a decision there ;)
|
LGTM |
This commit splits HasParentQueryParser into toQuery and fromXContent. This change also deprecates several keys in favor of simplified settings and adds basic unittests for HasParentQueryParser. Relates to elastic#10217
s1monw
force-pushed
the
has_parent_split
branch
from
9e41e1c to
d2e53e0
Compare
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits HasParentQueryParser into toQuery and fromXContent.
This change also deprecates several keys in favor of simplified settings
and adds basic unittests for HasParentQueryParser.