Add stats_bucket / extended_stats_bucket pipeline aggs
#13128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
changed the title
stats_bucket / extended_stats_bucket pipeline aggs
|
|
||
| public class InternalStatsBucket extends InternalStats implements StatsBucket { | ||
|
|
||
| public final static Type TYPE = new Type("internal_stats_bucket"); |
There was a problem hiding this comment.
I would use the same type name as the StatsPipelineAggregator here so it's easy to see they relate. That's what we do on other aggregations. The contexts in which these are used and deserialised are different so the names would never clash
|
Left a couple of comments but I think this is looking good. |
|
Comments addressed! |
|
LGTM |
polyfractal
force-pushed
the
feature/stats_pipeline
branch
2 times, most recently
from
068e9b7 to
d90bd80
Compare
…gations These are the complements to the stats/extended_stats metric aggregations, and can be used to calculate a variety of statistics over buckets
polyfractal
force-pushed
the
feature/stats_pipeline
branch
from
d90bd80 to
397d5be
Compare
polyfractal
added a commit
that referenced
this pull request
Sep 4, 2015
Aggregations: Add stats_bucket / extended_stats_bucket pipeline aggs
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the complements to the stats/extended_stats metric aggregations, and can be used
to calculate a variety of statistics over buckets
Pretty straight forward addition, but a few notes:
metrics.stats.InternalStats&metrics.stats.extended.ExtendedInternalStatsto reduce copy/paste of basically the same codeStatsBucketPipelineAggregator.registerStreams()for example). I thought this was cleaner than cluttering up the SearchModule registration list with 2x registrations for each, but happy to change if this is too indirectStatsBucket&ExtendedStatsBucket) which are basically just identical subclasses of the metric versions. Thought it would still be good to have these for the end-user./cc @colings86 if you have some spare time, no rush though.