Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run template simulation actions on local node #120038

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

nielsbauman
Copy link
Contributor

@nielsbauman nielsbauman commented Jan 13, 2025

The actions TransportSimulateTemplateAction and
TransportSimulateIndexTemplateAction solely need the cluster state, they can run on any node. Additionally, they need to be cancellable to avoid doing unnecessary work after a client failure or timeout.

As a drive-by, this removes more usages of the trappy default master node timeout.

Relates #101805
Relates #107984

The actions `TransportSimulateTemplateAction` and
`TransportSimulateIndexTemplateAction` solely need the cluster state,
they can run on any node. Additionally, they need to be cancellable
to avoid doing unnecessary work after a client failure or timeout.

As a drive-by, this removes another usage of the trappy default master
node timeout.
@nielsbauman nielsbauman added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v9.0.0 labels Jan 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @nielsbauman, I've created a changelog YAML for you.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Niels!

@nielsbauman nielsbauman merged commit 27a9c4d into elastic:main Jan 14, 2025
16 checks passed
@nielsbauman nielsbauman deleted the local-simulate branch January 14, 2025 02:41
martijnvg pushed a commit to martijnvg/elasticsearch that referenced this pull request Jan 14, 2025
The actions `TransportSimulateTemplateAction` and
`TransportSimulateIndexTemplateAction` solely need the cluster state,
they can run on any node. Additionally, they need to be cancellable
to avoid doing unnecessary work after a client failure or timeout.

As a drive-by, this removes more usages of the trappy default master
node timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants