[build] include in plugins only needed jars #11944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on discussion https://github.com/elastic/elasticsearch-analysis-kuromoji/issues/61, we don't need to include all transitive dependencies as they are already provided.
Follow up for https://github.com/elastic/elasticsearch-analysis-kuromoji/issues/61 We don't shade anymore elasticsearch dependencies, so plugins might include jars in the distribution ZIP file which might not be needed anymore. For example, `elasticsearch-cloud-aws` comes with: ``` Archive: cloud-aws/target/releases/elasticsearch-cloud-aws-2.0.0-SNAPSHOT.zip Length Date Time Name -------- ---- ---- ---- 1920788 05-18-15 09:42 aws-java-sdk-ec2-1.9.34.jar 503963 05-18-15 09:42 aws-java-sdk-core-1.9.34.jar 232771 01-19-15 09:24 commons-codec-1.6.jar 915096 01-19-15 09:24 jackson-databind-2.3.2.jar 252288 05-18-15 09:42 aws-java-sdk-kms-1.9.34.jar 62050 01-19-15 09:24 commons-logging-1.1.3.jar 282269 10-31-14 13:19 httpcore-4.3.2.jar 35058 01-19-15 09:24 jackson-annotations-2.3.0.jar 229998 05-29-15 12:28 jackson-core-2.5.3.jar 589289 01-19-15 09:24 joda-time-2.7.jar 562858 05-18-15 09:42 aws-java-sdk-s3-1.9.34.jar 590533 10-31-14 13:19 httpclient-4.3.5.jar 44854 06-12-15 19:22 elasticsearch-cloud-aws-2.0.0-SNAPSHOT.jar -------- ------- 6221815 13 files ``` A lot of those files are already distributed with elasticsearch itself so classes are available within the classloader. Closes elastic#11647. First step. Needs some other work...
|
looks good to me, thanks for tackling this! Hopefully we get a chance to tackle #11935 and we will have a running "test" in jenkins for these issues. |
|
Closed by e429b8d |
|
You sure you didn't delete one too many? Creating an S3 repo with master (as-of today) of elastic search tree, with the cloud-was plugin from the same tree results in missing classes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't shade anymore elasticsearch dependencies, so plugins might include jars in the distribution ZIP file which might not be needed anymore.
For example,
elasticsearch-cloud-awscomes with:A lot of those files are already distributed with elasticsearch itself so classes are available within the classloader.
Closes #11647.
If accepted, I'll most likely squash all commits in a single one.