-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skips synonym test in mixed cluster BwC tests #119044
Merged
carlosdelest
merged 2 commits into
elastic:main
from
carlosdelest:fix/synonyms-test-excluded-mixed-cluster
Jan 7, 2025
Merged
Skips synonym test in mixed cluster BwC tests #119044
carlosdelest
merged 2 commits into
elastic:main
from
carlosdelest:fix/synonyms-test-excluded-mixed-cluster
Jan 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
added
>test
Issues or PRs that are addressing/adding tests
:Search Relevance/Analysis
How text is split into tokens
auto-backport
Automatically create backport pull requests when merged
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v8.16.0
v9.0.0
v8.17.0
v8.18.0
labels
Dec 19, 2024
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
approved these changes
Jan 7, 2025
mayya-sharipova
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Carlos
💔 Backport failed
You can use sqren/backport to manually backport by running |
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Jan 7, 2025
…mpat (elastic#119044) (cherry picked from commit cc0e53e) # Conflicts: # muted-tests.yml # qa/mixed-cluster/build.gradle
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Jan 7, 2025
…mpat (elastic#119044) (cherry picked from commit cc0e53e) # Conflicts: # muted-tests.yml # qa/mixed-cluster/build.gradle
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Jan 7, 2025
…mpat (elastic#119044) (cherry picked from commit cc0e53e) # Conflicts: # muted-tests.yml # qa/mixed-cluster/build.gradle
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Jan 7, 2025
…mpat (elastic#119044) (cherry picked from commit cc0e53e) # Conflicts: # muted-tests.yml # qa/mixed-cluster/build.gradle
sarog
pushed a commit
to sarog/elasticsearch
that referenced
this pull request
Jan 22, 2025
…mpat (elastic#119044) (elastic#119664) (cherry picked from commit cc0e53e) # Conflicts: # muted-tests.yml # qa/mixed-cluster/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
backport pending
:Search Relevance/Analysis
How text is split into tokens
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
>test
Issues or PRs that are addressing/adding tests
v8.15.6
v8.16.0
v8.17.0
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116777
Follow up to #118691
The problematic test should be skipped in the mixed cluster test, not in the YAML rest compatibility. I double checked that all tests failures have been in mixed cluster tests, and that the test is skipped there.