Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Automatically apply spotless changes in pull request CI #118701

Merged
merged 6 commits into from
Dec 13, 2024
Merged

[CI] Automatically apply spotless changes in pull request CI #118701

merged 6 commits into from
Dec 13, 2024

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Dec 13, 2024 •
edited
Loading

  • Run spotlessApply during PR CI
  • If changes are present after running spotless, automatically commit them (which will also trigger a new CI run)
  • If changes on a subsequent run are still present even after auto-committing, error out

dd49b46 was made automatically as a test.

@brianseeders brianseeders added >non-issue Team:Delivery Meta label for Delivery team :Delivery/Tooling Developer tooliing and automation v9.0.0 v8.16.2 v8.17.1 v8.18.0 labels Dec 13, 2024
@brianseeders brianseeders marked this pull request as ready for review December 13, 2024 21:35
@brianseeders brianseeders requested a review from a team as a code owner December 13, 2024 21:35
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

mark-vieira
mark-vieira approved these changes Dec 13, 2024
View reviewed changes
.buildkite/scripts/spotless.sh Outdated Show resolved Hide resolved
@brianseeders brianseeders merged commit f900ae6 into elastic:main Dec 13, 2024
13 of 16 checks passed
@brianseeders brianseeders deleted the auto-spotless branch December 13, 2024 22:32
This was referenced Dec 13, 2024
Merged
Merged
brianseeders added a commit to brianseeders/elasticsearch that referenced this pull request Dec 13, 2024
@brianseeders
[CI] Automatically apply spotless changes in pull request CI (elastic…
123ac47 
…#118701)

(cherry picked from commit f900ae6)
@brianseeders brianseeders mentioned this pull request Dec 13, 2024
Merged
brianseeders added a commit to brianseeders/elasticsearch that referenced this pull request Dec 13, 2024
@brianseeders
[CI] Automatically apply spotless changes in pull request CI (elastic…
6e958ad 
…#118701)

(cherry picked from commit f900ae6)
brianseeders added a commit to brianseeders/elasticsearch that referenced this pull request Dec 13, 2024
@brianseeders
[CI] Automatically apply spotless changes in pull request CI (elastic…
10bde92 
…#118701)

(cherry picked from commit f900ae6)
@brianseeders
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 8.17
✅ 8.16
✅ 7.17

Questions ?

Please refer to the Backport tool documentation

@brianseeders brianseeders mentioned this pull request Dec 13, 2024
Merged
brianseeders added a commit to brianseeders/elasticsearch that referenced this pull request Dec 13, 2024
@brianseeders
[CI] Automatically apply spotless changes in pull request CI (elastic…
424ab70 
…#118701)

(cherry picked from commit f900ae6)
brianseeders added a commit that referenced this pull request Dec 16, 2024
@brianseeders
[CI] Automatically apply spotless changes in pull request CI (#118701) (
fc4622e 
#118712)

(cherry picked from commit f900ae6)
brianseeders added a commit that referenced this pull request Dec 16, 2024
@brianseeders
[CI] Automatically apply spotless changes in pull request CI (#118701) (
84fe783 
#118711)

(cherry picked from commit f900ae6)
brianseeders added a commit that referenced this pull request Dec 16, 2024
@brianseeders
[CI] Automatically apply spotless changes in pull request CI (#118701) (
75a46ce 
#118710)

(cherry picked from commit f900ae6)
brianseeders added a commit that referenced this pull request Dec 16, 2024
@brianseeders
[CI] Automatically apply spotless changes in pull request CI (#118701) (
4da564a 
#118709)

(cherry picked from commit f900ae6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

Assignees
No one assigned
Labels
:Delivery/Tooling Developer tooliing and automation >non-issue Team:Delivery Meta label for Delivery team v7.17.27 v8.16.2 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianseeders @elasticsearchmachine @mark-vieira