Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Ignore failures from renormalizing buckets in read-only index #118674

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

valeriy42
Copy link
Contributor

@valeriy42 valeriy42 commented Dec 13, 2024

In anomaly detection, score renomarmalize will update the anomaly score in the result indices. However, if the index in the old format was marked as read-only, the score update will fail. Since this failure is expected, this PR suppresses the error logging in this specific case.

@valeriy42 valeriy42 added :ml Machine learning v8.18.0 labels Dec 13, 2024
@valeriy42 valeriy42 self-assigned this Dec 13, 2024
@valeriy42 valeriy42 added >enhancement auto-backport Automatically create backport pull requests when merged labels Dec 13, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @valeriy42, I've created a changelog YAML for you.

@valeriy42 valeriy42 marked this pull request as ready for review December 17, 2024 09:56
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@valeriy42 valeriy42 requested a review from davidkyle December 17, 2024 09:57
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriy42 valeriy42 merged commit 6d943e9 into elastic:main Dec 17, 2024
2 of 4 checks passed
valeriy42 added a commit to valeriy42/elasticsearch that referenced this pull request Dec 17, 2024
…lastic#118674)

In anomaly detection, score renormalization will update the anomaly score in the result indices. However, if the index in the old format was marked as read-only, the score update will fail. Since this failure is expected, this PR suppresses the error logging in this specific case.
elasticsearchmachine pushed a commit that referenced this pull request Dec 17, 2024
…118674) (#118886)

In anomaly detection, score renormalization will update the anomaly score in the result indices. However, if the index in the old format was marked as read-only, the score update will fail. Since this failure is expected, this PR suppresses the error logging in this specific case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >enhancement :ml Machine learning Team:ML Meta label for the ML team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants