-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Ignore failures from renormalizing buckets in read-only index #118674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriy42
added
>enhancement
auto-backport
Automatically create backport pull requests when merged
labels
Dec 13, 2024
Hi @valeriy42, I've created a changelog YAML for you. |
…renorm-readonly-indices
Pinging @elastic/ml-core (Team:ML) |
davidkyle
reviewed
Dec 17, 2024
...rc/main/java/org/elasticsearch/xpack/ml/job/persistence/JobRenormalizedResultsPersister.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/ml/job/persistence/JobRenormalizedResultsPersister.java
Outdated
Show resolved
Hide resolved
…persistence/JobRenormalizedResultsPersister.java Co-authored-by: David Kyle <[email protected]>
…persistence/JobRenormalizedResultsPersister.java Co-authored-by: David Kyle <[email protected]>
…2/elasticsearch into renorm-readonly-indices
davidkyle
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...rc/main/java/org/elasticsearch/xpack/ml/job/persistence/JobRenormalizedResultsPersister.java
Outdated
Show resolved
Hide resolved
…persistence/JobRenormalizedResultsPersister.java Co-authored-by: David Kyle <[email protected]>
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Dec 17, 2024
…lastic#118674) In anomaly detection, score renormalization will update the anomaly score in the result indices. However, if the index in the old format was marked as read-only, the score update will fail. Since this failure is expected, this PR suppresses the error logging in this specific case.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
…118674) (#118886) In anomaly detection, score renormalization will update the anomaly score in the result indices. However, if the index in the old format was marked as read-only, the score update will fail. Since this failure is expected, this PR suppresses the error logging in this specific case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>enhancement
:ml
Machine learning
Team:ML
Meta label for the ML team
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anomaly detection, score renomarmalize will update the anomaly score in the result indices. However, if the index in the old format was marked as
read-only
, the score update will fail. Since this failure is expected, this PR suppresses the error logging in this specific case.