Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bucketOrd field from InternalTerms and friends #118044

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Dec 5, 2024

The field bucketOrd is only used for building the aggregation but has no use after that and is not serialize. This commit refactors the way we build the aggregation so we can remove it.

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@iverase iverase added the auto-backport Automatically create backport pull requests when merged label Dec 5, 2024
@iverase iverase merged commit 422eb1a into elastic:main Dec 5, 2024
16 checks passed
@iverase iverase deleted the bucketOrdTerms branch December 5, 2024 14:25
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

iverase added a commit to iverase/elasticsearch that referenced this pull request Dec 5, 2024
The field bucketOrd is only used for building the aggregation but has no use after that.
elasticsearchmachine pushed a commit that referenced this pull request Dec 5, 2024
)

The field bucketOrd is only used for building the aggregation but has no use after that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants