Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against missing file in CI upload #117889

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Dec 3, 2024

Somehow files can be lost before the build ends up uploading them, presumable from temporarily file deletion after tests complete. This commit guards against this case so that the build will not completely fail, but instead log a warning.

Somehow files can be lost before the build ends up uploading them,
presumable from temporarily file deletion after tests complete. This
commit guards against this case so that the build will not completely
fail, but instead log a warning.
@rjernst rjernst added :Delivery/Build Build or test infrastructure >refactoring labels Dec 3, 2024
@rjernst rjernst requested a review from a team as a code owner December 3, 2024 12:26
@rjernst rjernst added v9.0.0 v8.18.0 auto-backport Automatically create backport pull requests when merged labels Dec 3, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Dec 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit c1a9d44 into elastic:main Dec 3, 2024
17 checks passed
@rjernst rjernst deleted the build/missing_file_upload branch December 3, 2024 16:42
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Dec 3, 2024
Somehow files can be lost before the build ends up uploading them,
presumable from temporarily file deletion after tests complete. This
commit guards against this case so that the build will not completely
fail, but instead log a warning.
elasticsearchmachine pushed a commit that referenced this pull request Dec 3, 2024
Somehow files can be lost before the build ends up uploading them,
presumable from temporarily file deletion after tests complete. This
commit guards against this case so that the build will not completely
fail, but instead log a warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure >refactoring Team:Delivery Meta label for Delivery team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants