Parse the contents of dynamic objects for [subobjects:false] #117762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
added
>bug
auto-backport
|
Hi @kkrik-es, I've created a changelog YAML for you. |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Dec 2, 2024
lkts
reviewed
Dec 2, 2024
| refresh: true | ||
| body: | ||
| - '{ "index": { } }' | ||
| - '{ "my": { "keyword.field": "abc" } }' |
There was a problem hiding this comment.
Can we have a test that introducing a dynamic field throws in this case?
lkts
approved these changes
Dec 3, 2024
| body: | ||
| fields: [ "*" ] | ||
|
|
||
| - match: { hits.hits.0.fields: { my.keyword.field: [ abc ] } } |
There was a problem hiding this comment.
You'll need to sort results for this test to work with multiple shards.
There was a problem hiding this comment.
Keep forgetting that.. Done.
|
|
||
| doc = mapper.parse(source(""" | ||
| { "metrics": { "service": { "test.other.dots": "foo" } } }""")); | ||
| assertNull(doc.rootDoc().getField("metrics.service.test.with.dots")); |
There was a problem hiding this comment.
Suggested change
| assertNull(doc.rootDoc().getField("metrics.service.test.with.dots")); | |
| assertNull(doc.rootDoc().getField("metrics.service.test.other.dots")); |
here and below?
# Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
💔 Backport failed
You can use sqren/backport to manually backport by running |
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Dec 3, 2024
…#117762) * Parse the contents of dynamic objects for [subobjects:false] * Update docs/changelog/117762.yaml * add tests * tests * test dynamic field * test dynamic field * fix tests
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Dec 3, 2024
…#117762) * Parse the contents of dynamic objects for [subobjects:false] * Update docs/changelog/117762.yaml * add tests * tests * test dynamic field * test dynamic field * fix tests (cherry picked from commit f2addbc) # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 3, 2024
#117919) * Parse the contents of dynamic objects for [subobjects:false] * Update docs/changelog/117762.yaml * add tests * tests * test dynamic field * test dynamic field * fix tests
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 3, 2024
#117921) * Parse the contents of dynamic objects for [subobjects:false] * Update docs/changelog/117762.yaml * add tests * tests * test dynamic field * test dynamic field * fix tests (cherry picked from commit f2addbc) # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocumentParserskips parsing dynamic objects when[dynamic:false]is set in a parent object. When[subobjects:false]is also set, dynamic objects should be flattened instead.Fixes #117544