Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deprecation warning for data_frame_transforms roles #117521

Conversation

dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Nov 25, 2024

Issue - https://github.com/elastic/ml-team/issues/1389

Description

The data_frame_transforms_user and data_frame_transforms_admin roles have been marked as deprected for some time now. This change adds a critical deprecation warning that will block users from migrating to 9.0 until they update any transforms using these roles to instead use the equivalent transforms_user and transforms_admin roles. The process to do this is outlined in the documentation added in this PR. This documentation is currently not published and the location is not finalized. As such, the deprecation warning currently has an elastic URL that we can update once the documentation is published. This PR does not need to be blocked on the documentation change as we can dynamically change what it points to through the elastic links UI without need for a follow-up code review.

Testing

  • Unit tests
  • Manually created a transform with each/both of the deprecated roles and confirmed that a deprecation warning was found when calling the deprecations API

@dan-rubinstein dan-rubinstein added >non-issue :ml Machine learning Team:ML Meta label for the ML team v9.0.0 v8.18.0 labels Nov 25, 2024
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Nov 25, 2024
@dan-rubinstein dan-rubinstein removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Nov 25, 2024
@dan-rubinstein dan-rubinstein added the auto-backport Automatically create backport pull requests when merged label Dec 9, 2024
@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

@dan-rubinstein dan-rubinstein marked this pull request as ready for review December 9, 2024 17:08
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@dan-rubinstein dan-rubinstein merged commit 98e69c8 into elastic:main Dec 9, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Dec 9, 2024
…17521)

* Adding deprecation warning for data_frame_transforms roles

* Updating deprecation warning URL

---------

Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Dec 9, 2024
…118294)

* Adding deprecation warning for data_frame_transforms roles

* Updating deprecation warning URL

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :ml Machine learning >non-issue Team:ML Meta label for the ML team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants