Always Emit Inference ID in Semantic Text Mapping #117294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
Hi @Mikep86, I've created a changelog YAML for you. |
kderusso
reviewed
Nov 21, 2024
|
@elasticmachine update branch |
carlosdelest
approved these changes
Nov 22, 2024
Mikep86
added
the
auto-backport
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Nov 22, 2024
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Nov 22, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 22, 2024
Samiul-TheSoccerFan
added a commit
to elastic/kibana
that referenced
this pull request
Nov 26, 2024
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]>
Samiul-TheSoccerFan
added a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Nov 26, 2024
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit b3d638b) # Conflicts: # x-pack/plugins/translations/translations/zh-CN.json
Samiul-TheSoccerFan
added a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Nov 26, 2024
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit b3d638b) # Conflicts: # x-pack/plugins/translations/translations/zh-CN.json
Samiul-TheSoccerFan
added a commit
to elastic/kibana
that referenced
this pull request
Nov 26, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Remove hardcoded preconfigured ELSER endpoint (#201300)](#201300) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T14:42:20Z","message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"number":201300,"url":"https://github.com/elastic/kibana/pull/201300","mergeCommit":{"message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201300","number":201300,"mergeCommit":{"message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Samiul-TheSoccerFan
added a commit
to elastic/kibana
that referenced
this pull request
Nov 26, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [Remove hardcoded preconfigured ELSER endpoint (#201300)](#201300) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T14:42:20Z","message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"number":201300,"url":"https://github.com/elastic/kibana/pull/201300","mergeCommit":{"message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201300","number":201300,"mergeCommit":{"message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201811","number":201811,"state":"OPEN"}]}] BACKPORT-->
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]>
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always emit the
inference_idparam when writing asemantic_textfield mapping to XContent.