Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Fix invariant test in TOP(bytes) #117049

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Nov 19, 2024

Fixes a self-test in the code for TOP(bytes), specifically around the merging used for grouping by ordinals.

Fixes a self-test in the code for `TOP(bytes)`, specifically around
the merging used for grouping by ordinals.
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v9.0.0 v8.17.0 labels Nov 19, 2024
@nik9000 nik9000 requested a review from ivancea November 19, 2024 17:55
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@ivancea ivancea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It seems like a hard-to-spot "bug" 👀

@nik9000 nik9000 merged commit d5bc389 into elastic:main Nov 20, 2024
16 checks passed
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Nov 20, 2024
Fixes a self-test in the code for `TOP(bytes)`, specifically around
the merging used for grouping by ordinals.
@nik9000
Copy link
Member Author

nik9000 commented Nov 20, 2024

Backport: #117166

elasticsearchmachine pushed a commit that referenced this pull request Nov 20, 2024
Fixes a self-test in the code for `TOP(bytes)`, specifically around
the merging used for grouping by ordinals.
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Nov 20, 2024
Fixes a self-test in the code for `TOP(bytes)`, specifically around
the merging used for grouping by ordinals.
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Fixes a self-test in the code for `TOP(bytes)`, specifically around
the merging used for grouping by ordinals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants