Disable KqlQueryBuilderTests on non-snapshots build. #117025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afoucret
added
>test-failure
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
afoucret
commented
Nov 20, 2024
x-pack/plugin/kql/build.gradle
Outdated
Comment on lines
29
to
38
| tasks.named('yamlRestTest').configure { | ||
| usesDefaultDistribution() | ||
|
|
||
| /**************************************************************** | ||
| * Enable QA/rest integration tests for snapshot builds only * | ||
| * TODO: Enable for all builds upon this feature release * | ||
| ****************************************************************/ | ||
| enabled = buildParams.isSnapshotBuild() | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not necessary anymore, since it is controlled by a capability.
| @@ -34,6 +36,10 @@ | |||
| import static org.hamcrest.Matchers.nullValue; | |||
|
|
|||
| public class KqlQueryBuilderTests extends AbstractQueryTestCase<KqlQueryBuilder> { | |||
| @Before | |||
There was a problem hiding this comment.
I think the following works as well, so it avoids skipping the individual tests?
Suggested change
| @Before | |
| @BeforeClass |
carlosdelest
approved these changes
Nov 20, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 20, 2024
(cherry picked from commit 537bba6) # Conflicts: # muted-tests.yml # x-pack/plugin/kql/build.gradle
afoucret
added a commit
that referenced
this pull request
Nov 20, 2024
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #116487