Unmute Categorize VerifierTests and require snapshot on them #117016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks for taking this, @ivancea !
Looks good, just a minor suggestion :)
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
💔 Backport failed
You can use sqren/backport to manually backport by running |
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Nov 22, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 22, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116856
Fixes #116857
Fixes #116858