-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for type, fields, copy_to and boost in metadata field definition #116944
Remove support for type, fields, copy_to and boost in metadata field definition #116944
Conversation
…definition Support for type, fields, copy_to and boost in metadata field definition has been deprecated in elastic#90989. Such fields have been long parsed and silently ignored. This commit removes support for their parsing.
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Hi @javanna, I've created a changelog YAML for you. Note that since this PR is labelled |
I tried to add the
Which adds a warning under the Executing the same request and applying the PR changes, I get the response, which seems ok to me.
|
Thanks for the testing @drempapis and the review ! Indeed, these fields received special treatment before because they could potentially be provided, although without taking any effect. With my change, they get the same treatment as any other unknown field. |
…definition (elastic#116944) Support for type, fields, copy_to and boost in metadata field definition has been deprecated in elastic#90989. Such fields have been long parsed and silently ignored.
…definition (elastic#116944) Support for type, fields, copy_to and boost in metadata field definition has been deprecated in elastic#90989. Such fields have been long parsed and silently ignored.
We removed support for type, fields, copy_to and boost in metadata field definitions with elastic#116944 but with the move towards supporting N-2 read-only indices we need to add them back. This change reverts previous removal commits and adapts tests to also check we now throw errors for newly created indices.
We removed support for type, fields, copy_to and boost in metadata field definitions with #116944 but with the move towards supporting N-2 read-only indices we need to add them back. This change reverts previous removal commits and adapts tests to also check we now throw errors for newly created indices.
Support for type, fields, copy_to and boost in metadata field definition has been deprecated in #90989. Such fields have been long parsed and silently ignored.
This commit removes support for their parsing.