Removing testGet from muted tests as it no longer exists #116735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
>test
elasticsearchmachine
added
the
external-contributor
dan-rubinstein
removed
the
external-contributor
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
Nov 13, 2024
dan-rubinstein
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
dan-rubinstein
removed
backport pending
auto-backport
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 13, 2024
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 14, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #114135
Removing
testGetfrom muted tests. Explanation for why from the issue above:Looks like testGet was updated to testCRUD in this change. Looking back at the assertion that was failing, it looks related to the total number of endpoints we expect to exist (see here). testCRUD is not muted and has not been failing so it seems the updates we've made should have accounted for this. I'll go ahead and remove this from the muted tests.