Add license check for ES|QL functions #116715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
iverase
changed the title
ivancea
approved these changes
Nov 14, 2024
.../esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Verifier.java
Outdated
Show resolved
Hide resolved
craigtaverner
approved these changes
Nov 14, 2024
.../esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java
Show resolved
Hide resolved
...n/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/CheckLicenseTests.java
Show resolved
Hide resolved
iverase
added
the
auto-backport
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Nov 19, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 19, 2024
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no license checks on ESQL, which it means that all functionality is offer in basic license. We however oversee that some functionality might be offer in higher tier licenses so we need to add the necessary means to do license checks.
One of the obvious one would be to license some functions, therefore this commit adds license checks on the Verifier. Any function would be able to check the current license and flag if the can run under the current one.