Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML test for status in indices stats #116711

Conversation

DaveCTurner
Copy link
Contributor

The feature added in #81954 lacks coverage in BwC situations. This
commit adds a YAML test to address that.

The feature added in elastic#81954 lacks coverage in BwC situations. This
commit adds a YAML test to address that.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Data Management/Stats Statistics tracking and retrieval APIs v9.0.0 labels Nov 13, 2024
@DaveCTurner DaveCTurner requested review from gmarouli and 3kt November 13, 2024 10:16
Copy link
Contributor

@3kt 3kt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but my review probably doesn't carry much weight ;) )

@DaveCTurner DaveCTurner requested a review from ywangd November 14, 2024 10:19
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The PR #81954 also added health to the indices stats. Shoud we test that as well?

@DaveCTurner DaveCTurner merged commit 17d2803 into elastic:main Nov 29, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the 2024/11/13/indices-stats-status-yaml-test branch November 29, 2024 09:54
@DaveCTurner
Copy link
Contributor Author

The PR #81954 also added health to the indices stats. Shoud we test that as well?

Probably, but I'm not going to do that here. Progress over perfection and all that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Stats Statistics tracking and retrieval APIs >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants