Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmutes #116332 after backporting tests to v8.x #116612

Merged

Conversation

carlosdelest
Copy link
Member

Closes #116332

Follow up to #116609

Test fixes done in #116224 had not been backported to v8.x, which causes BwC tests to fail when 8.x tests are executed against main.

After backporting in #116609, unmute tests so we can check this is solved.

@carlosdelest carlosdelest added >test Issues or PRs that are addressing/adding tests :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Nov 11, 2024
@carlosdelest carlosdelest marked this pull request as ready for review November 12, 2024 10:23
@carlosdelest carlosdelest requested a review from a team as a code owner November 12, 2024 10:23
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@benwtrent
Copy link
Member

@carlosdelest seems like your branch has some unnecessary commits, etc.

@carlosdelest carlosdelest force-pushed the tests/unmute-synonyms-test-116332 branch from 0203a9b to 8153ffc Compare November 12, 2024 15:51
@carlosdelest
Copy link
Member Author

@benwtrent Thanks - now it makes sense

@carlosdelest carlosdelest merged commit f529e12 into elastic:main Nov 12, 2024
16 checks passed
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Nov 12, 2024
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Nov 14, 2024
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
3 participants