Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

char_filter pattern_replace error requires at least java 21 #116507

Conversation

benwtrent
Copy link
Member

This test requires at least java 21, skip it otherwise.

closes: #116405
closes: #116134

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team :Search Relevance/Search Catch all for Search Relevance v8.16.1 v8.17.0 v8.15.5 labels Nov 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@@ -30,6 +28,12 @@ dependencies {
clusterModules project(':modules:mapper-extras')
}

tasks.named("yamlRestTest").configure { task->
if (BuildParams.getRuntimeJavaVersion().majorVersion.toInteger() < 21) {
task.skipTest("analysis-common/50_char_filters/pattern_replace error handling (too complex pattern)", "Requires Java 21 or later")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipTest doesn't exist on this task. That method is only on compat task transform tasks so this will fail. You'll want to use the blacklist system property instead. Example:

if (BuildParams.isSnapshotBuild() == false) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looking at the CI failure you'll need to an import for BuildParams in that build scripts.

import org.elasticsearch.gradle.internal.info.BuildParams

@benwtrent benwtrent requested a review from mark-vieira November 8, 2024 17:14
Copy link
Contributor

@afoucret afoucret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thank your for handling it.

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 11, 2024
@benwtrent
Copy link
Member Author

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 91b4b1e into elastic:8.x Nov 11, 2024
14 of 15 checks passed
@benwtrent benwtrent deleted the test/skipping-116134-on-earlier-javas branch November 11, 2024 14:06
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.16 Commit could not be cherrypicked due to conflicts
8.15 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 116507

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Nov 11, 2024
…116507)

This test requires at least java 21, skip it otherwise.

closes: elastic#116405 closes:
elastic#116134
(cherry picked from commit 91b4b1e)
@benwtrent
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.16
8.15

Questions ?

Please refer to the Backport tool documentation

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Nov 11, 2024
…116507)

This test requires at least java 21, skip it otherwise.

closes: elastic#116405 closes:
elastic#116134
(cherry picked from commit 91b4b1e)
elasticsearchmachine pushed a commit that referenced this pull request Nov 11, 2024
…#116597)

This test requires at least java 21, skip it otherwise.

closes: #116405 closes:
#116134
(cherry picked from commit 91b4b1e)
benwtrent added a commit that referenced this pull request Nov 11, 2024
…#116598)

This test requires at least java 21, skip it otherwise.

closes: #116405 closes:
#116134
(cherry picked from commit 91b4b1e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending :Search Relevance/Search Catch all for Search Relevance :SearchOrg/Relevance Label for the Search (solution/org) Relevance team >test Issues or PRs that are addressing/adding tests v8.15.5 v8.16.1 v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants