-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
char_filter pattern_replace error requires at least java 21 #116507
char_filter pattern_replace error requires at least java 21 #116507
Conversation
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Pinging @elastic/search-eng (Team:SearchOrg) |
Pinging @elastic/search-relevance (Team:Search - Relevance) |
modules/analysis-common/build.gradle
Outdated
@@ -30,6 +28,12 @@ dependencies { | |||
clusterModules project(':modules:mapper-extras') | |||
} | |||
|
|||
tasks.named("yamlRestTest").configure { task-> | |||
if (BuildParams.getRuntimeJavaVersion().majorVersion.toInteger() < 21) { | |||
task.skipTest("analysis-common/50_char_filters/pattern_replace error handling (too complex pattern)", "Requires Java 21 or later") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skipTest
doesn't exist on this task. That method is only on compat task transform tasks so this will fail. You'll want to use the blacklist system property instead. Example:
elasticsearch/docs/build.gradle
Line 41 in 510a56b
if (BuildParams.isSnapshotBuild() == false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looking at the CI failure you'll need to an import for BuildParams
in that build scripts.
import org.elasticsearch.gradle.internal.info.BuildParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thank your for handling it.
@elasticmachine update branch |
@elasticmachine update branch |
💔 Backport failed
You can use sqren/backport to manually backport by running |
…116507) This test requires at least java 21, skip it otherwise. closes: elastic#116405 closes: elastic#116134 (cherry picked from commit 91b4b1e)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…116507) This test requires at least java 21, skip it otherwise. closes: elastic#116405 closes: elastic#116134 (cherry picked from commit 91b4b1e)
This test requires at least java 21, skip it otherwise.
closes: #116405
closes: #116134