Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix testMaybeConvertToBytesRefStringCorrectSize #116386

Merged

Conversation

piergm
Copy link
Member

@piergm piergm commented Nov 7, 2024

randomIntBetween is inclusive while we want max to be exclusive.
Relates to: #115655
Fix already in backport PR #116381

@piergm piergm added >non-issue :Search Foundations/Search Catch all for Search Foundations v9.0.0 labels Nov 7, 2024
@piergm piergm self-assigned this Nov 7, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Nov 7, 2024
@piergm piergm added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Nov 7, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this Matteo

@piergm piergm merged commit bf3fcb7 into elastic:main Nov 7, 2024
16 checks passed
kderusso pushed a commit to kderusso/elasticsearch that referenced this pull request Nov 7, 2024
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants