Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DesiredBalanceComputer#hasComputationConverged #116331

Conversation

pxsalehi
Copy link
Member

@pxsalehi pxsalehi commented Nov 6, 2024

@pxsalehi pxsalehi added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels Nov 6, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Nov 6, 2024
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pxsalehi pxsalehi added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 6, 2024
@pxsalehi pxsalehi changed the title Refactor DesiredBalanceComputer#hasEnoughIterations Refactor DesiredBalanceComputer#hasComputationConverged Nov 6, 2024
@pxsalehi
Copy link
Member Author

pxsalehi commented Nov 6, 2024

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 8db9181 into elastic:main Nov 6, 2024
16 checks passed
@pxsalehi pxsalehi deleted the ps241106-change-hasComputationConverged branch November 6, 2024 18:21
jozala pushed a commit that referenced this pull request Nov 13, 2024
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) needs:triage Requires assignment of a team area label >non-issue v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants