Revert dynamic entitlement #116315
Closed
Revert dynamic entitlement #116315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Packaging
|
Pinging @elastic/es-delivery (Team:Delivery) |
ldematte
requested changes
Nov 6, 2024
There was a problem hiding this comment.
I think @davidkyle mentioned that is due to ML upgrading the build system to Windows 2022 on the main branch elastic/ml-cpp#2769
It does make sense, since it is failing at ML plugin creation (and CI is still failing with this revert too).
Can you check with David before merging the revert please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #116125 to revert failing packaging tests on windows
see #116299
see #116314